refactor(cache): move the task fs story into crates/vt_fs_fingerprint - #594
Open
wan9chi wants to merge 1 commit into
Open
refactor(cache): move the task fs story into crates/vt_fs_fingerprint#594wan9chi wants to merge 1 commit into
wan9chi wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
claude/extract-filesystem-tracing-e49e4b
branch
3 times, most recently
from
August 7, 2026 07:23
0fd6243 to
f53d2d1
Compare
The task_fs module already mirrors a standalone crate: lift it out of the engine wholesale so the unsettled read-write-overlap policy has a home that is tested with synthetic traces instead of whole-engine runs. The engine keeps storage, archiving, env tracking, and spawning; rayon, twox-hash, and wax leave its dependency list with the moved code. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
wan9chi
force-pushed
the
claude/extract-filesystem-tracing-e49e4b
branch
from
August 9, 2026 03:06
f53d2d1 to
ad96d42
Compare
This was referenced Aug 9, 2026
wan9chi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
task_fsmodule introduced in #601 already mirrors a standalone crate — this lifts it out of the engine wholesale (stack: 3/3), so the unsettled read-write-overlap policy has a home that is reasoned about and tested on its own, with synthetic traces instead of whole-engine runs.Six of the seven moved files are zero-diff renames (
hash.rschanges two lines:pub(super)is redundant at a crate root). The genuinely new content is the crate manifest, a 22-linelib.rsof re-exports, and the README documenting the boundary and its design rationale. The engine keeps storage, archiving, env tracking, and spawning;rayon,twox-hash, andwaxleave its dependency list with the moved code.🤖 Generated with Claude Code